Bug 160710 - Calling splitText() on a parent-less Text node should update associated ranges
Summary: Calling splitText() on a parent-less Text node should update associated ranges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-08-09 14:48 PDT by Chris Dumez
Modified: 2016-08-09 18:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.08 KB, patch)
2016-08-09 14:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-09 14:48:59 PDT 
Calling splitText() on a parent-less Text node should update associated ranges:
- https://dom.spec.whatwg.org/#concept-text-split (Step 9)

We currently only update ranges for Text nodes that have a parent.
Comment 1 Chris Dumez 2016-08-09 14:54:18 PDT 
Created attachment 285679 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-09 15:32:14 PDT 
Comment on attachment 285679 [details]
Patch

Clearing flags on attachment: 285679

Committed r204311: <http://trac.webkit.org/changeset/204311>
Comment 3 WebKit Commit Bot 2016-08-09 15:32:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2016-08-09 17:37:01 PDT 
This changed caused fast/dom/non-numeric-values-numeric-parameters.html to crash due to failing: ASSERT(oldNode->nextSibling())

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html
Comment 5 Chris Dumez 2016-08-09 18:11:56 PDT 
(In reply to comment #4)
> This changed caused fast/dom/non-numeric-values-numeric-parameters.html to
> crash due to failing: ASSERT(oldNode->nextSibling())
> 
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html

Looking, thanks.
Comment 6 Chris Dumez 2016-08-09 18:18:45 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > This changed caused fast/dom/non-numeric-values-numeric-parameters.html to
> > crash due to failing: ASSERT(oldNode->nextSibling())
> > 
> > https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html
> 
> Looking, thanks.

Should be fixed in <http://trac.webkit.org/changeset/204319>.