Bug 160710 – Calling splitText() on a parent-less Text node should update associated ranges

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Calling splitText() on a parent-less Text node should update associated ranges:
- https://dom.spec.whatwg.org/#concept-text-split (Step 9)

We currently only update ranges for Text nodes that have a parent.

[Chris Dumez]

Created attachment 285679 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 285679 [details]
Patch

Clearing flags on attachment: 285679

Committed r204311: <http://trac.webkit.org/changeset/204311>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This changed caused fast/dom/non-numeric-values-numeric-parameters.html to crash due to failing: ASSERT(oldNode->nextSibling())

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html

[Chris Dumez]

(In reply to comment #4)
> This changed caused fast/dom/non-numeric-values-numeric-parameters.html to
> crash due to failing: ASSERT(oldNode->nextSibling())
> 
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html

Looking, thanks.

[Chris Dumez]

(In reply to comment #5)
> (In reply to comment #4)
> > This changed caused fast/dom/non-numeric-values-numeric-parameters.html to
> > crash due to failing: ASSERT(oldNode->nextSibling())
> > 
> > https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html
> 
> Looking, thanks.

Should be fixed in <http://trac.webkit.org/changeset/204319>.