Bug 160699 – [WK2] Only send gamepad input events to the currently focused page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

[WK2] Only send gamepad input events to the currently focused page

[Brady Eidson]

Created attachment 285688 [details]
Patch v1

[Brady Eidson]

Created attachment 285692 [details]
Attempt to fix 32bit build

[Tim Horton]

Comment on attachment 285692 [details]
Attempt to fix 32bit build

View in context: https://bugs.webkit.org/attachment.cgi?id=285692&action=review

> Source/WebKit2/UIProcess/Gamepad/mac/UIGamepadProviderMac.mm:41
> +    if ([responder class] == [WKWebView class])

This is very wrong, you want [responder isKindOfClass:[WKWebView class]] (and below). Otherwise subclasses will fail.

[Tim Horton]

Comment on attachment 285692 [details]
Attempt to fix 32bit build

View in context: https://bugs.webkit.org/attachment.cgi?id=285692&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:873
> +- (WebPageProxy*) _webPageProxy

instead of adding this, can't you toImpl(webView.pageRef) or something like that?

[Brady Eidson]

Created attachment 285694 [details]
Another 32bit build fix attempt

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 285692 [details]
> Attempt to fix 32bit build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285692&action=review
> 
> > Source/WebKit2/UIProcess/Gamepad/mac/UIGamepadProviderMac.mm:41
> > +    if ([responder class] == [WKWebView class])
> 
> This is very wrong, you want [responder isKindOfClass:[WKWebView class]]
> (and below). Otherwise subclasses will fail.

Right.

(In reply to comment #4)
> Comment on attachment 285692 [details]
> Attempt to fix 32bit build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285692&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKView.mm:873
> > +- (WebPageProxy*) _webPageProxy
> 
> instead of adding this, can't you toImpl(webView.pageRef) or something like
> that?

Oooooh toImpl...  okay.

[Brady Eidson]

Created attachment 285696 [details]
Yay much better

[Brady Eidson]

Created attachment 285698 [details]
Now with more building, and for landing.

[WebKit Commit Bot]

Attachment 285698 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Gamepad/mac/UIGamepadProviderMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 285698 [details]
Now with more building, and for landing.

Clearing flags on attachment: 285698

Committed r204318: <http://trac.webkit.org/changeset/204318>