WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160694
Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=160694
Summary
Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
Anders Carlsson
Reported
2016-08-09 09:35:39 PDT
Move Plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
Attachments
Patch
(14.23 KB, patch)
2016-08-09 09:36 PDT
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2016-08-09 09:36:45 PDT
Created
attachment 285643
[details]
Patch
mitz
Comment 2
2016-08-09 09:57:26 PDT
Comment on
attachment 285643
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=285643&action=review
> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:65 > + NSArray* pluginsArray = [[WebPluginDatabase sharedDatabase] plugins];
Star on the wrong side of the space. Use .plugins.
> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:66 > + for (unsigned i = 0; i < [pluginsArray count]; ++i) {
Use fast enumeration.
> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:69 > + plugins.append([plugin pluginInfo]);
Use .pluginInfo.
Anders Carlsson
Comment 3
2016-08-09 09:59:09 PDT
Committed
r204282
: <
http://trac.webkit.org/changeset/204282
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug