Bug 160694 - Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
Summary: Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-09 09:35 PDT by Anders Carlsson
Modified: 2016-08-09 09:59 PDT (History)
0 users

See Also:


Attachments
Patch (14.23 KB, patch)
2016-08-09 09:36 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-09 09:35:39 PDT
Move Plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
Comment 1 Anders Carlsson 2016-08-09 09:36:45 PDT
Created attachment 285643 [details]
Patch
Comment 2 mitz 2016-08-09 09:57:26 PDT
Comment on attachment 285643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285643&action=review

> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:65
> +    NSArray* pluginsArray = [[WebPluginDatabase sharedDatabase] plugins];

Star on the wrong side of the space. Use .plugins.

> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:66
> +    for (unsigned i = 0; i < [pluginsArray count]; ++i) {

Use fast enumeration.

> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:69
> +        plugins.append([plugin pluginInfo]);

Use .pluginInfo.
Comment 3 Anders Carlsson 2016-08-09 09:59:09 PDT
Committed r204282: <http://trac.webkit.org/changeset/204282>