Bug 160672 – Have the iOS platform interit from the Apple platform in webkitpy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Have the iOS platform interit from the Apple platform in webkitpy

[Simon Fraser (smfr)]

Created attachment 285599 [details]
Patch

[Daniel Bates]

Comment on attachment 285599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285599&action=review

We need to rebase this patch to pick up the changes in <https://trac.webkit.org/changeset/204253> (bug #159827).

> Tools/Scripts/webkitpy/port/apple.py:212
> +    def sample_process(self, name, pid):
> +        try:
> +            hang_report = self.sample_file_path(name, pid)
> +            self._executive.run_command([
> +                "/usr/bin/sample",
> +                pid,
> +                10,
> +                10,
> +                "-file",
> +                hang_report,
> +            ])
> +        except ScriptError as e:
> +            _log.warning('Unable to sample process:' + str(e))

This implementation is out-of-date. We need to merge in the logic from <https://trac.webkit.org/changeset/204253> (bug #159827).

> Tools/Scripts/webkitpy/port/mac.py:159
> +        # FIXME: this is unused. Remove.

Nit: this => This

[Simon Fraser (smfr)]

Created attachment 285602 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 285602 [details]
Patch

Carrying Dan's r+ forwards

[Simon Fraser (smfr)]

https://trac.webkit.org/r204271

[Jonathan Bedard]

Architectural question: why do EFL and GTK inherit from "Port" but Windows inherits from ApplePort?  I was actually working on a similar change, except I created a new port (called Darwin) that both IOS and Mac inherited from, essentially to avoid the special cases you defined for Windows.

[Simon Fraser (smfr)]

I think Windows inherits from ApplePort because it is a port maintained by Apple, but I don't know if we get any benefit from it using ApplePort. I think your proposed Darwin port makes more sense.

[Jonathan Bedard]

Created attachment 285657 [details]
iOS and Mac ports inherit from a shared Darwin port

The Python script didn't work (not sure why, will debug that after lunch).  Here is the manual upload

[Jonathan Bedard]

https://bugs.webkit.org/show_bug.cgi?id=160709 extends the changes in this patch.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/204271