Bug 160672 - Have the iOS platform interit from the Apple platform in webkitpy
Summary: Have the iOS platform interit from the Apple platform in webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-08 16:05 PDT by Simon Fraser (smfr)
Modified: 2016-08-11 13:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (29.95 KB, patch)
2016-08-08 16:08 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (30.94 KB, patch)
2016-08-08 16:18 PDT, Simon Fraser (smfr)
simon.fraser: review+
Details | Formatted Diff | Diff
iOS and Mac ports inherit from a shared Darwin port (27.96 KB, patch)
2016-08-09 12:02 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-08-08 16:05:52 PDT
Have the iOS platform interit from the Apple platform in webkitpy
Comment 1 Simon Fraser (smfr) 2016-08-08 16:08:33 PDT
Created attachment 285599 [details]
Patch
Comment 2 Daniel Bates 2016-08-08 16:16:47 PDT
Comment on attachment 285599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285599&action=review

We need to rebase this patch to pick up the changes in <https://trac.webkit.org/changeset/204253> (bug #159827).

> Tools/Scripts/webkitpy/port/apple.py:212
> +    def sample_process(self, name, pid):
> +        try:
> +            hang_report = self.sample_file_path(name, pid)
> +            self._executive.run_command([
> +                "/usr/bin/sample",
> +                pid,
> +                10,
> +                10,
> +                "-file",
> +                hang_report,
> +            ])
> +        except ScriptError as e:
> +            _log.warning('Unable to sample process:' + str(e))

This implementation is out-of-date. We need to merge in the logic from <https://trac.webkit.org/changeset/204253> (bug #159827).

> Tools/Scripts/webkitpy/port/mac.py:159
> +        # FIXME: this is unused. Remove.

Nit: this => This
Comment 3 Simon Fraser (smfr) 2016-08-08 16:18:17 PDT
Created attachment 285602 [details]
Patch
Comment 4 Simon Fraser (smfr) 2016-08-08 17:24:10 PDT
Comment on attachment 285602 [details]
Patch

Carrying Dan's r+ forwards
Comment 5 Simon Fraser (smfr) 2016-08-08 17:24:24 PDT
https://trac.webkit.org/r204271
Comment 6 Jonathan Bedard 2016-08-09 09:36:13 PDT
Architectural question: why do EFL and GTK inherit from "Port" but Windows inherits from ApplePort?  I was actually working on a similar change, except I created a new port (called Darwin) that both IOS and Mac inherited from, essentially to avoid the special cases you defined for Windows.
Comment 7 Simon Fraser (smfr) 2016-08-09 10:11:52 PDT
I think Windows inherits from ApplePort because it is a port maintained by Apple, but I don't know if we get any benefit from it using ApplePort. I think your proposed Darwin port makes more sense.
Comment 8 Jonathan Bedard 2016-08-09 12:02:36 PDT
Created attachment 285657 [details]
iOS and Mac ports inherit from a shared Darwin port

The Python script didn't work (not sure why, will debug that after lunch).  Here is the manual upload
Comment 9 Jonathan Bedard 2016-08-09 14:25:27 PDT
https://bugs.webkit.org/show_bug.cgi?id=160709 extends the changes in this patch.
Comment 10 Simon Fraser (smfr) 2016-08-11 13:31:10 PDT
https://trac.webkit.org/changeset/204271