Bug 160671 – Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Created attachment 285595 [details]
Repro test case.

Steps to repro:

1. Apply the following patch to disable the function cache.

Index: Source/JavaScriptCore/parser/Parser.cpp
===================================================================
--- Source/JavaScriptCore/parser/Parser.cpp     (revision 204127)
+++ Source/JavaScriptCore/parser/Parser.cpp     (working copy)
@@ -1954,6 +1954,7 @@ template <class TreeBuilder> bool Parser
     FunctionBodyType functionBodyType;
 
     auto loadCachedFunction = [&] () -> bool {
+        if (true) return false;
         ASSERT(parametersStart != -1);
         ASSERT(startColumn != -1);
 
2. Run jsc on the attached test case.

It ends up throwing the following invalid error:

Exception: ReferenceError: Can't find variable: inner
/Volumes/Data/objcjsc/tests/test.js:9:52
foo2@/Volumes/Data/objcjsc/tests/test.js:12:17
goo2@/Volumes/Data/objcjsc/tests/test.js:14:9
global code@/Volumes/Data/objcjsc/tests/test.js:15:3

[Radar WebKit Bug Importer]

<rdar://problem/27756112>

[Saam Barati]

Created attachment 285666 [details]
patch

[Mark Lam]

Comment on attachment 285666 [details]
patch

r=me

[WebKit Commit Bot]

Comment on attachment 285666 [details]
patch

Clearing flags on attachment: 285666

Committed r204305: <http://trac.webkit.org/changeset/204305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.