Add a new PluginInfoProvider class, to replace PluginStrategy
Created attachment 285593 [details] Patch
Attachment 285593 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 3 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 285593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285593&action=review > Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.h:26 > +#import <WebCore/PluginInfoProvider.h> Missing #pragma once. > Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h:26 > +#include <WebCore/PluginInfoProvider.h> Missing #pragma once
Created attachment 285594 [details] Patch
Attachment 285594 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 3 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 285596 [details] Patch
Attachment 285596 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r204268: <http://trac.webkit.org/changeset/204268>
CMake build fix Committed r204548: <http://trac.webkit.org/changeset/204548>