Bug 160670 - Add a new PluginInfoProvider class, to replace PluginStrategy
Summary: Add a new PluginInfoProvider class, to replace PluginStrategy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 160775
Blocks:
  Show dependency treegraph
 
Reported: 2016-08-08 15:36 PDT by Anders Carlsson
Modified: 2016-08-16 20:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (56.68 KB, patch)
2016-08-08 15:40 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (56.72 KB, patch)
2016-08-08 15:48 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (57.73 KB, patch)
2016-08-08 16:03 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-08 15:36:32 PDT
Add a new PluginInfoProvider class, to replace PluginStrategy
Comment 1 Anders Carlsson 2016-08-08 15:40:40 PDT
Created attachment 285593 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-08 15:43:00 PDT
Attachment 285593 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:30:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 3 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2016-08-08 15:45:48 PDT
Comment on attachment 285593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285593&action=review

> Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.h:26
> +#import <WebCore/PluginInfoProvider.h>

Missing #pragma once.

> Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h:26
> +#include <WebCore/PluginInfoProvider.h>

Missing #pragma once
Comment 4 Anders Carlsson 2016-08-08 15:48:00 PDT
Created attachment 285594 [details]
Patch
Comment 5 WebKit Commit Bot 2016-08-08 15:49:47 PDT
Attachment 285594 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:30:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 3 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2016-08-08 16:03:40 PDT
Created attachment 285596 [details]
Patch
Comment 7 WebKit Commit Bot 2016-08-08 16:04:51 PDT
Attachment 285596 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Anders Carlsson 2016-08-08 16:45:19 PDT
Committed r204268: <http://trac.webkit.org/changeset/204268>
Comment 9 Hunseop Jeong 2016-08-16 20:48:38 PDT
CMake build fix
Committed r204548: <http://trac.webkit.org/changeset/204548>