Bug 160664 – It should be possible to re-initialize a CustomEvent after it's been dispatched

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

It should be possible to re-initialize a CustomEvent after it's been dispatched:
- https://dom.spec.whatwg.org/#dom-customevent-initcustomevent

[Chris Dumez]

Created attachment 285574 [details]
Patch

[Build Bot]

Comment on attachment 285574 [details]
Patch

Attachment 285574 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1835786

New failing tests:
http/tests/security/aboutBlank/security-context-alias.html
http/tests/xmlhttprequest/document-domain-set.html
http/tests/workers/worker-document-domain-security.html
http/tests/security/aboutBlank/security-context-grandchildren-alias.html
http/tests/security/postMessage/origin-unaffected-by-document-domain.html
fast/scrolling/ios/scroll-events-back-forward.html

[Build Bot]

Created attachment 285580 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 285574 [details]
> Patch
> 
> Attachment 285574 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/1835786
> 
> New failing tests:
> http/tests/security/aboutBlank/security-context-alias.html
> http/tests/xmlhttprequest/document-domain-set.html
> http/tests/workers/worker-document-domain-security.html
> http/tests/security/aboutBlank/security-context-grandchildren-alias.html
> http/tests/security/postMessage/origin-unaffected-by-document-domain.html
> fast/scrolling/ios/scroll-events-back-forward.html

iOs failures seem unrelated :/

-PASS: XMLHttpRequest allowed with document.domain set.
+CONSOLE MESSAGE: line 9: TypeError: window.internals.settings.setTreatIPAddressAsDomain is not a function. (In 'window.internals.settings.setTreatIPAddressAsDomain(true)', 'window.internals.settings.setTreatIPAddressAsDomain' is undefined)

[Ryan Haddad]

(In reply to comment #4)
> iOs failures seem unrelated :/
> 
> -PASS: XMLHttpRequest allowed with document.domain set.
> +CONSOLE MESSAGE: line 9: TypeError:
> window.internals.settings.setTreatIPAddressAsDomain is not a function. (In
> 'window.internals.settings.setTreatIPAddressAsDomain(true)',
> 'window.internals.settings.setTreatIPAddressAsDomain' is undefined)

Thanks for the heads up. I believe these tests became flaky with https://trac.webkit.org/changeset/204260.

[Alex Christensen]

Comment on attachment 285574 [details]
Patch

Is there no web platform test for this?

[Chris Dumez]

(In reply to comment #6)
> Comment on attachment 285574 [details]
> Patch
> 
> Is there no web platform test for this?

There was for Event (see https://bugs.webkit.org/show_bug.cgi?id=160664), but not for Event subclasses.

[WebKit Commit Bot]

Comment on attachment 285574 [details]
Patch

Clearing flags on attachment: 285574

Committed r204288: <http://trac.webkit.org/changeset/204288>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.