Align Selection API with the specification:
In particular, the following changes need to be made:
- Mark parameters as non-nullable when they should be.
- Mark parameters as mandatory when they should be.
- Use "unsigned long" type for offsets instead of "long".
Created attachment 285572 [details]
Created attachment 285573 [details]
Comment on attachment 285573 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=285573&action=review
> + void setBaseAndExtent(Node baseNode, unsigned long baseOffset, Node extentNode, unsigned long extentOffset);
I think we should preserve the old behavior of clearing selection when baseNode/extentNode is null.
Created attachment 285579 [details]
Comment on attachment 285579 [details]
Clearing flags on attachment: 285579
Committed r204263: <http://trac.webkit.org/changeset/204263>
All reviewed patches have been landed. Closing bug.