Bug 160637 – [Web IDL] Add support for [Unscopable] extended attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Add support for [Unscopable] extended attribute:
- http://heycam.github.io/webidl/#Unscopable

[Chris Dumez]

Created attachment 285501 [details]
Patch

[Darin Adler]

Comment on attachment 285501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285501&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2186
> +    push(@implContent, "    JSObject* unscopables = constructEmptyObject(globalObject()->globalExec(), globalObject()->nullPrototypeObjectStructure());\n");

I would use a reference for this. I know we don’t do that in JavaScriptCore itself, but I would like to do that in bindings.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2188
> +        push(@implContent, "    unscopables->putDirect(vm, Identifier::fromString(&vm, \"${unscopable}\"), jsBoolean(true));\n");

Braces are optional in ${unscopable} here and I would have omitted them.

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1353
> +    JSObject* unscopables = constructEmptyObject(globalObject()->globalExec(), globalObject()->nullPrototypeObjectStructure());

Ditto.

[Chris Dumez]

Created attachment 285514 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 285514 [details]
Patch

Clearing flags on attachment: 285514

Committed r204234: <http://trac.webkit.org/changeset/204234>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.