Bug 160635 - Web Inspector: clean up prefixing of Automation protocol generated files
Summary: Web Inspector: clean up prefixing of Automation protocol generated files
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
Keywords: InRadar
Depends on:
Reported: 2016-08-06 14:55 PDT by BJ Burg
Modified: 2016-08-08 09:45 PDT (History)
11 users (show)

See Also:

Proposed Fix (28.12 KB, patch)
2016-08-06 21:37 PDT, BJ Burg
timothy: review+
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-08-06 14:55:17 PDT
Comment 1 Radar WebKit Bug Importer 2016-08-06 14:55:30 PDT
Comment 2 BJ Burg 2016-08-06 21:37:01 PDT
Created attachment 285520 [details]
Proposed Fix
Comment 3 BJ Burg 2016-08-06 21:37:25 PDT
Comment on attachment 285520 [details]
Proposed Fix

Needs to be landed with internal changes, do not cq+.
Comment 4 WebKit Commit Bot 2016-08-06 21:38:16 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 5 WebKit Commit Bot 2016-08-06 21:38:23 PDT
Attachment 285520 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:97:  [ObjCGenerator.protocol_name] Instance of 'ObjCGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:51:  [CppGenerator.protocol_name] Instance of 'CppGenerator' has no 'model' member  [pylint/E1101] [5]
Total errors found: 2 in 18 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 BJ Burg 2016-08-08 09:45:09 PDT
Committed r204255: <http://trac.webkit.org/changeset/204255>