Bug 160632 - EWS Style Queue fails to process patches which fails validation
Summary: EWS Style Queue fails to process patches which fails validation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-06 11:32 PDT by Aakash Jain
Modified: 2016-08-06 22:20 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch, also added a unittest. (3.07 KB, patch)
2016-08-06 11:39 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-08-06 11:32:00 PDT
Currently EWS Style Queue has 19 pending patches. Looking at the logs on the machine, there is an exception while processing any patch which fails validation. It is because of the change done is https://bugs.webkit.org/show_bug.cgi?id=159903 in PatchIsNotValid class.
Comment 1 Aakash Jain 2016-08-06 11:39:37 PDT
Created attachment 285491 [details]
Proposed patch, also added a unittest.
Comment 2 WebKit Commit Bot 2016-08-06 12:34:35 PDT
Comment on attachment 285491 [details]
Proposed patch, also added a unittest.

Clearing flags on attachment: 285491

Committed r204230: <http://trac.webkit.org/changeset/204230>
Comment 3 WebKit Commit Bot 2016-08-06 12:34:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Aakash Jain 2016-08-06 22:20:47 PDT
Style queue processed all the pending patches after the fix.