Bug 160630 – Fix some minor problems in the StringImpl header

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Darin Adler]

Fix some minor problems in the StringImpl header

[Darin Adler]

Created attachment 285483 [details]
Patch

[Darin Adler]

Brady, notice the false positives from check-webkit-style here.

[WebKit Commit Bot]

Attachment 285483 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/text/StringImpl.h:670:  'simplifyWhiteSpace' is incorrectly named. It should be named 'protector' or 'protectedCodeUnitMatchFunction'.  [readability/naming/protected] [4]
ERROR: Source/WTF/wtf/text/StringImpl.h:672:  'stripLeadingAndTrailingCharacters' is incorrectly named. It should be named 'protector' or 'protectedCodeUnitMatchFunction'.  [readability/naming/protected] [4]
ERROR: Source/WTF/wtf/text/StringImpl.h:673:  'removeCharacters' is incorrectly named. It should be named 'protector' or 'protectedCodeUnitMatchFunction'.  [readability/naming/protected] [4]
Total errors found: 3 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Windows error:

C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebCoreSupport\WebChromeClient.cpp)
C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebView.cpp(3758): error C2065: 'TextCaseSensitive': undeclared identifier [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj]
C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebView.cpp(3758): error C2065: 'TextCaseInsensitive': undeclared identifier [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj]
C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebView.cpp(3758): error C2660: 'WebCore::Page::markAllMatchesForText': function does not take 3 arguments [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj]
  WebEditorClient.cpp

It looks like WebChromeClient.cpp and WebView.cpp need to know that 'TextCaseSensitivity' was moved to JavascriptCore/yarr.

[Brent Fulgham]

The GTK build failures looks like the device ran out of space, not due to a problem with this patch.

[Brent Fulgham]

Comment on attachment 285483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285483&action=review

The patch breaks the Windows build. r- to correct that problem.

> Source/JavaScriptCore/ChangeLog:15
> +        the only place it is used.

It looks like you need to make similar RegularExpression -> JSC::Yarr::RegularExpression changes in the Windows code, too.

[Brent Fulgham]

Comment on attachment 285483 [details]
Patch

Actually, r+ but please fix the JSC::Yarr namespacing in the Windows code before landing.

[Darin Adler]

Committed r225144: <https://trac.webkit.org/changeset/225144>

[Radar WebKit Bug Importer]

<rdar://problem/35685297>