Bug 160625 - Add LEBDecoder and tests
Summary: Add LEBDecoder and tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-05 19:26 PDT by Keith Miller
Modified: 2016-08-05 20:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (25.45 KB, patch)
2016-08-05 19:29 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-08-05 19:26:03 PDT 
Add LEBDecoder and tests
Comment 1 Keith Miller 2016-08-05 19:29:42 PDT 
Created attachment 285475 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-05 19:30:59 PDT 
Attachment 285475 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/testWASM.cpp:74:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:87:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:93:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:99:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:103:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:122:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:130:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:135:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:141:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:147:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/testWASM.cpp:151:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/LEBDecoder.h:32:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 13 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2016-08-05 20:28:26 PDT 
(In reply to comment #2)
> Attachment 285475 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/testWASM.cpp:74:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:82:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:87:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:93:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:99:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:103:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:122:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:130:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:135:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:141:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:147:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/JavaScriptCore/testWASM.cpp:151:  Weird number of spaces at
> line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/WTF/wtf/LEBDecoder.h:32:  Bad include order. Mixing system and
> custom headers.  [build/include_order] [4]
> Total errors found: 13 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

The style checker doesn't seem to like the comments in the macros.
Comment 4 WebKit Commit Bot 2016-08-05 20:49:34 PDT 
Comment on attachment 285475 [details]
Patch

Clearing flags on attachment: 285475

Committed r204218: <http://trac.webkit.org/changeset/204218>
Comment 5 WebKit Commit Bot 2016-08-05 20:49:38 PDT 
All reviewed patches have been landed.  Closing bug.