WTF needs a variant implementation
Created attachment 285468 [details] Patch
Created attachment 285473 [details] Patch
Comment on attachment 285473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285473&action=review Sweeeeet! > Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:47 > + typedef std::experimental::variant<int, float, String> Variant; Do we want to type std::experimental::variant every time we use this in WebKit, or do we want to put this line in the header?
(In reply to comment #3) > Comment on attachment 285473 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285473&action=review > > Sweeeeet! > > > Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:47 > > + typedef std::experimental::variant<int, float, String> Variant; > > Do we want to type std::experimental::variant every time we use this in > WebKit, or do we want to put this line in the header? I think for now we want to type it. As I start using it, if it becomes annoying, I will consider adding something like: namespace WTF { template<typename ... Types> using Variant = std::experimental::variant<Types>; } But I want to see first.
Comment on attachment 285473 [details] Patch Clearing flags on attachment: 285473 Committed r204227: <http://trac.webkit.org/changeset/204227>
All reviewed patches have been landed. Closing bug.
The failures in bug 160638 make it seem likely this is not quite working yet in the compilers used on the GTK and Windows bots.