RESOLVED FIXED160615
[JSC] Remove the first LocalCSE 
https://bugs.webkit.org/show_bug.cgi?id=160615
Summary [JSC] Remove the first LocalCSE
Benjamin Poulain
Reported 2016-08-05 15:45:35 PDT
[JSC] Remove the first LocalCSE
Attachments
Patch (1.60 KB, patch)
2016-08-05 16:48 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-08-05 16:48:26 PDT
Created attachment 285463 [details] Patch
Benjamin Poulain
Comment 2 2016-08-05 16:48:51 PDT
Conf#1 Conf#2 SunSpider: 3d-cube 4.6946+-0.0707 4.6763+-0.0614 3d-morph 5.0088+-0.0475 ? 5.0349+-0.0576 ? 3d-raytrace 4.9393+-0.0855 4.9310+-0.0456 access-binary-trees 1.9989+-0.0482 1.9640+-0.0206 might be 1.0177x faster access-fannkuch 5.8231+-0.0881 5.7150+-0.0474 might be 1.0189x faster access-nbody 2.3827+-0.0280 ? 2.3997+-0.0271 ? access-nsieve 2.9891+-0.0669 2.9548+-0.0339 might be 1.0116x faster bitops-3bit-bits-in-byte 1.0695+-0.0140 1.0579+-0.0128 might be 1.0110x faster bitops-bits-in-byte 2.6419+-0.0557 2.5672+-0.0250 might be 1.0291x faster bitops-bitwise-and 2.0234+-0.0400 1.9886+-0.0223 might be 1.0175x faster bitops-nsieve-bits 3.0801+-0.0222 ? 3.0965+-0.0212 ? controlflow-recursive 2.3314+-0.0404 2.3202+-0.0462 crypto-aes 4.4379+-0.0401 4.3876+-0.0551 might be 1.0115x faster crypto-md5 2.6843+-0.0458 ? 2.7041+-0.1053 ? crypto-sha1 2.7254+-0.0205 ? 2.7823+-0.0714 ? might be 1.0209x slower date-format-tofte 6.5622+-0.0760 ? 6.6129+-0.0990 ? date-format-xparb 4.7637+-0.0849 4.6974+-0.0356 might be 1.0141x faster math-cordic 2.7627+-0.0584 2.7569+-0.0518 math-partial-sums 3.9813+-0.0351 ? 4.0601+-0.0822 ? might be 1.0198x slower math-spectral-norm 2.0540+-0.0366 2.0192+-0.0331 might be 1.0172x faster regexp-dna 6.4314+-0.1218 6.3864+-0.1062 string-base64 4.0432+-0.0878 3.9400+-0.0208 might be 1.0262x faster string-fasta 5.5192+-0.0241 ? 5.5538+-0.0846 ? string-tagcloud 8.4850+-0.1800 8.3181+-0.0855 might be 1.0201x faster string-unpack-code 18.3935+-0.4016 ? 18.4756+-0.4208 ? string-validate-input 4.1084+-0.0496 4.0712+-0.0445 <arithmetic> 4.4590+-0.0203 4.4412+-0.0214 might be 1.0040x faster Conf#1 Conf#2 Octane: encrypt 0.15512+-0.00134 ? 0.15581+-0.00152 ? decrypt 2.75649+-0.01762 ? 2.76441+-0.02085 ? deltablue x2 0.13236+-0.00410 0.13208+-0.00099 earley 0.28501+-0.00065 ? 0.28502+-0.00097 ? boyer 4.96796+-0.03607 4.91271+-0.04338 might be 1.0112x faster navier-stokes x2 4.93473+-0.00768 4.92821+-0.00826 raytrace x2 0.79216+-0.00248 ? 0.79278+-0.00355 ? richards x2 0.08246+-0.00059 0.08230+-0.00059 splay x2 0.33759+-0.00091 ? 0.33769+-0.00125 ? regexp x2 16.27552+-0.19037 16.22184+-0.28990 pdfjs x2 38.22263+-0.14252 ? 38.41836+-0.15404 ? mandreel x2 42.61658+-0.13496 ? 42.67755+-0.12576 ? gbemu x2 29.35006+-0.10124 ! 29.54697+-0.08443 ! definitely 1.0067x slower closure 0.48129+-0.00114 ? 0.48150+-0.00126 ? jquery 6.42046+-0.02032 6.40381+-0.01316 box2d x2 9.17845+-0.02549 ? 9.20429+-0.02761 ? zlib x2 360.24211+-4.05535 356.38140+-3.20667 might be 1.0108x faster typescript x2 598.48664+-3.47155 596.19601+-2.74135 <geometric> 4.99687+-0.01150 4.99432+-0.00839 might be 1.0005x faster Conf#1 Conf#2 Kraken: ai-astar 86.761+-0.682 86.286+-0.874 audio-beat-detection 38.836+-0.081 ? 38.860+-0.092 ? audio-dft 98.832+-1.162 97.916+-1.070 audio-fft 30.209+-0.059 ? 30.436+-0.382 ? audio-oscillator 48.233+-0.194 48.084+-0.174 imaging-darkroom 61.346+-0.572 61.262+-0.501 imaging-desaturate 44.205+-0.852 43.752+-0.166 might be 1.0104x faster imaging-gaussian-blur 60.930+-0.507 ? 61.179+-1.051 ? json-parse-financial 33.631+-0.189 ? 34.114+-0.370 ? might be 1.0144x slower json-stringify-tinderbox 22.601+-0.386 ? 22.977+-0.694 ? might be 1.0167x slower stanford-crypto-aes 36.955+-0.256 ? 37.161+-0.313 ? stanford-crypto-ccm 33.636+-0.754 ? 34.590+-0.841 ? might be 1.0284x slower stanford-crypto-pbkdf2 92.332+-0.185 ? 92.874+-0.713 ? stanford-crypto-sha256-iterative 30.449+-0.183 ? 30.458+-0.114 ? <arithmetic> 51.354+-0.141 ? 51.425+-0.136 ? might be 1.0014x slower Conf#1 Conf#2 AsmBench: bigfib.cpp 425.5875+-2.9817 422.4091+-1.5348 cray.c 384.0542+-0.9688 383.3284+-1.7021 dry.c 463.4703+-32.4541 451.0828+-26.6783 might be 1.0275x faster FloatMM.c 734.6912+-13.9452 725.9360+-11.0948 might be 1.0121x faster gcc-loops.cpp 3592.9345+-8.2533 3590.1066+-6.9193 n-body.c 798.8941+-1.1161 798.0131+-1.1199 Quicksort.c 392.2992+-1.6741 ? 393.8054+-2.1974 ? stepanov_container.cpp 3265.0545+-7.9133 ? 3279.3510+-10.0337 ? Towers.c 264.7045+-0.7679 264.4301+-0.6177 <geometric> 722.3204+-5.4208 719.1504+-4.4408 might be 1.0044x faster Conf#1 Conf#2 Geomean of preferred means: <scaled-result> 30.1503+-0.0741 30.0938+-0.0648 might be 1.0019x faster
Benjamin Poulain
Comment 3 2016-08-05 17:28:33 PDT
Comment on attachment 285463 [details] Patch Thanks Saam. Note to reviewers: Please do not roll out before we have all the perf numbers from the bots.
WebKit Commit Bot
Comment 4 2016-08-05 17:50:48 PDT
Comment on attachment 285463 [details] Patch Clearing flags on attachment: 285463 Committed r204207: <http://trac.webkit.org/changeset/204207>
WebKit Commit Bot
Comment 5 2016-08-05 17:50:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.