RESOLVED FIXED160604
REGRESSION (r201245): switching between Computed and Visual Styles panels causes internal error 
https://bugs.webkit.org/show_bug.cgi?id=160604
Summary REGRESSION (r201245): switching between Computed and Visual Styles panels cau...
Matt Baker
Reported 2016-08-05 11:54:36 PDT
Summary: Switching between Computed and Visual Styles panels causes internal error. Steps to Reproduce: 1. Open Inspector > Elements 2. Show Styles sidebar if necessary 3. Switch from Computed panel to Visual panel => [Error] TypeError: undefined is not an object (evaluating 'this._selectorSection.update') refresh — VisualStyleDetailsPanel.js:64 _refreshPreservingScrollPosition — StyleDetailsPanel.js:143 nodeStylesRefreshed — StyleDetailsPanel.js:114 dispatch — Object.js:162 dispatchEventToListeners — Object.js:169 fetchedComputedStyle — DOMNodeStyles.js:228 ... 4. When switching from Visual to Computed => [Error] TypeError: undefined is not an object (evaluating 'this._propertiesTextEditor.style = this.nodeStyles.computedStyle') refresh — ComputedStyleDetailsPanel.js:130 _refreshPreservingScrollPosition — StyleDetailsPanel.js:143 nodeStylesRefreshed — StyleDetailsPanel.js:114 dispatch — Object.js:162 dispatchEventToListeners — Object.js:169 fetchedComputedStyle — DOMNodeStyles.js:228 ... Note: I expected this to be a regression caused by https://trac.webkit.org/changeset/203253, but it looks like it was broken earlier.
Attachments
[Patch] Proposed Fix (1.58 KB, patch)
2016-08-07 12:11 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-05 11:54:57 PDT
<rdar://problem/27723416>
Matt Baker
Comment 2 2016-08-05 12:46:26 PDT
Regressed in https://trac.webkit.org/changeset/201245.
Radar WebKit Bug Importer
Comment 3 2016-08-05 12:46:53 PDT
<rdar://problem/27724305>
Matt Baker
Comment 4 2016-08-07 12:11:20 PDT
Created attachment 285530 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2016-08-07 12:42:24 PDT
Comment on attachment 285530 [details] [Patch] Proposed Fix Clearing flags on attachment: 285530 Committed r204244: <http://trac.webkit.org/changeset/204244>
WebKit Commit Bot
Comment 6 2016-08-07 12:42:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.