Bug 160599 - Create platform/gamepads directory, and make GamepadProvider pure virtual (with a default empty implementation)
Summary: Create platform/gamepads directory, and make GamepadProvider pure virtual (wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 134076 134675
  Show dependency tree / graph
 
Reported: 2016-08-05 09:54 PDT by Brady Eidson
Modified: 2016-08-08 03:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch (154.58 KB, patch)
2016-08-05 10:04 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (154.51 KB, patch)
2016-08-05 10:17 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (156.64 KB, patch)
2016-08-05 10:36 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-08-05 09:54:55 PDT 
Create platform/gamepads directory, and make GamepadProvider pure virtual (with a default empty implementation)
Comment 1 Brady Eidson 2016-08-05 10:04:22 PDT 
Created attachment 285426 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-05 10:06:24 PDT 
Attachment 285426 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gamepads/mac/HIDGamepad.cpp:73:  Use nullptr instead of NULL.  [readability/null] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2016-08-05 10:17:35 PDT 
Created attachment 285428 [details]
Patch
Comment 4 WebKit Commit Bot 2016-08-05 10:20:31 PDT 
Attachment 285428 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73:  Use nullptr instead of NULL.  [readability/null] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2016-08-05 10:36:49 PDT 
Created attachment 285433 [details]
Patch
Comment 6 WebKit Commit Bot 2016-08-05 10:39:35 PDT 
Attachment 285433 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73:  Use nullptr instead of NULL.  [readability/null] [5]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2016-08-05 11:29:12 PDT 
Comment on attachment 285433 [details]
Patch

Clearing flags on attachment: 285433

Committed r204178: <http://trac.webkit.org/changeset/204178>
Comment 8 WebKit Commit Bot 2016-08-05 11:29:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Csaba Osztrogonác 2016-08-08 03:25:45 PDT 
(In reply to comment #7)
> Comment on attachment 285433 [details]
> Patch
> 
> Clearing flags on attachment: 285433
> 
> Committed r204178: <http://trac.webkit.org/changeset/204178>

It broke the Apple Mac cmake build.