Bug 160598 - page/Chrome.cpp: Add ASSERT(frame) to catch nulls and eventually change frame from pointer to reference
Summary: page/Chrome.cpp: Add ASSERT(frame) to catch nulls and eventually change frame...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-05 09:40 PDT by John Wilander
Modified: 2016-08-05 09:40 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2016-08-05 09:40:30 PDT 
Brent Fulgham pointed the following out regarding page/Chrome.cpp:

It looks like frame is assumed to be non-null most places it is used. We should probably make it a reference in a future patch to help enforce this. I think we should add an "ASSERT(frame)" so we can catch cases where this assumption is not true.