Bug 160530 – Drop DocumentType.internalSubset attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Drop DocumentType.internalSubset attribute.

It is no longer in the DOM specification, and other browsers have already dropped it. In WebKit, it is always null anyway.

[Chris Dumez]

Created attachment 285288 [details]
Patch

[Alex Christensen]

Comment on attachment 285288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285288&action=review

> Source/WebCore/bindings/objc/DOMDocumentType.mm:77
> -    return IMPL->internalSubset();
> +    return IMPL->internalSubsetForBindings();

What are the implications of keeping the objc bindings when the javascript bindings are gone?  Before we started freezing the objc bindings, wouldn't we have removed the whole method?

[WebKit Commit Bot]

Comment on attachment 285288 [details]
Patch

Clearing flags on attachment: 285288

Committed r204114: <http://trac.webkit.org/changeset/204114>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 285288 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285288&action=review
> 
> > Source/WebCore/bindings/objc/DOMDocumentType.mm:77
> > -    return IMPL->internalSubset();
> > +    return IMPL->internalSubsetForBindings();
> 
> What are the implications of keeping the objc bindings when the javascript
> bindings are gone?  Before we started freezing the objc bindings, wouldn't
> we have removed the whole method?

No, before the freeze, we wouldn't have been able to remove the whole method. After the  freeze though we would in theory be able to remove the internalSubsetForBindings() method and hack the ObjC bindings to stop calling it. However, this is usually not possible because of GObject bindings.