Bug 160513 - Fix logging in W3C tests
Summary: Fix logging in W3C tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-03 10:41 PDT by Chris Dumez
Modified: 2016-08-03 11:36 PDT (History)
6 users (show)

See Also:


Attachments
Patch (224.16 KB, patch)
2016-08-03 10:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (229.86 KB, patch)
2016-08-03 11:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-03 10:41:20 PDT
Fix logging in W3C tests. Some W3C tests have no visible output or output in the wrong order because we fail to use the test's log <div> and always append the log lines to the body.
Comment 1 Chris Dumez 2016-08-03 10:43:13 PDT
Unfortunately, a lot of tests need to be rebaselined..
Comment 2 Chris Dumez 2016-08-03 10:49:51 PDT
Created attachment 285247 [details]
Patch
Comment 3 Chris Dumez 2016-08-03 11:01:57 PDT
Created attachment 285249 [details]
Patch
Comment 4 Chris Dumez 2016-08-03 11:03:26 PDT
Comment on attachment 285249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285249&action=review

> LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-childElementCount-expected.txt:5
> +The result of this test is given above.

Note that this test makes sense now.

> LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-insertAdjacentElement-expected.txt:4
> +PASS Inserted element should be target element's previous sibling for 'beforebegin' case 

Note that this test has expected results now.

> LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-insertAdjacentText-expected.txt:4
> +PASS Inserted text node should be target element's previous sibling for 'beforebegin' case 

Note that this test has expected results now.
Comment 5 Chris Dumez 2016-08-03 11:36:45 PDT
Comment on attachment 285249 [details]
Patch

Clearing flags on attachment: 285249

Committed r204090: <http://trac.webkit.org/changeset/204090>
Comment 6 Chris Dumez 2016-08-03 11:36:51 PDT
All reviewed patches have been landed.  Closing bug.