Bug 160506 - Duplicated code in DrawingAreaProxyImpl and CoordinatedDrawingAreaProxy
Summary: Duplicated code in DrawingAreaProxyImpl and CoordinatedDrawingAreaProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-08-03 07:18 PDT by Carlos Garcia Campos
Modified: 2016-08-07 22:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (62.67 KB, patch)
2016-08-03 07:26 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Try to fix EFL build (62.68 KB, patch)
2016-08-03 07:43 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Try to fix EFL build (62.72 KB, patch)
2016-08-03 07:48 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-08-03 07:18:21 PDT 
This is mostly the same than bug #159259, CoordinatedDrawingAreaProxy is just a copy paste of DrawingAreaProxyImpl with the non accelerated composited code path removed. We could reuse most of the code by subclassing.
Comment 1 Carlos Garcia Campos 2016-08-03 07:26:49 PDT 
Created attachment 285228 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-08-03 07:43:45 PDT 
Created attachment 285229 [details]
Try to fix EFL build
Comment 3 Carlos Garcia Campos 2016-08-03 07:48:30 PDT 
Created attachment 285230 [details]
Try to fix EFL build
Comment 4 Carlos Garcia Campos 2016-08-07 22:40:02 PDT 
Committed r204249: <http://trac.webkit.org/changeset/204249>