Bug 160502 - WebRTC: OWR: Add support for the muted state in the mediaplayer
Summary: WebRTC: OWR: Add support for the muted state in the mediaplayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-03 05:37 PDT by Alejandro G. Castro
Modified: 2016-08-04 03:56 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.98 KB, patch)
2016-08-03 05:59 PDT, Alejandro G. Castro
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2016-08-03 05:37:50 PDT
Currently the mediaplayer does not handle correctly the initial muted state of the tracks.
Comment 1 Alejandro G. Castro 2016-08-03 05:59:44 PDT
Created attachment 285221 [details]
Patch
Comment 2 Eric Carlson 2016-08-03 08:37:08 PDT
Comment on attachment 285221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285221&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:317
> +        GST_WARNING("Unmutting a track with None type");

Nit: "Unmutting" isn't always correct.
Comment 3 Alejandro G. Castro 2016-08-04 02:27:47 PDT
Committed r204118: <http://trac.webkit.org/changeset/204118>
Comment 4 Alejandro G. Castro 2016-08-04 03:56:31 PDT
(In reply to comment #2)
> Comment on attachment 285221 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285221&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:317
> > +        GST_WARNING("Unmutting a track with None type");
> 
> Nit: "Unmutting" isn't always correct.

Right, fixed for the commit, thanks.