Bug 16050 - sqlite3_prepare16_v2 build bustage.
Summary: sqlite3_prepare16_v2 build bustage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-19 09:02 PST by doug turner
Modified: 2007-11-19 10:02 PST (History)
0 users

See Also:


Attachments
Patch 1. (1.20 KB, patch)
2007-11-19 09:17 PST, doug turner
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description doug turner 2007-11-19 09:02:40 PST
in WebCore/platform/sql/SQLiteStatement.cpp, use of the function |sqlite3_prepare16_v2| is dependent on the SQLITE_VERSION_NUMBER being greater than 3.3.0.  (line 53).   |sqlite3_prepare16_v2| was introduced in SQLITE_VERSION_NUMBER 3.3.9  (according to http://www.sqlite.org/cvstrac/wiki?p=WhenPreparedStatementExpire).

Anyone using sqlite version between 3.3.1 and 3.3.9 will not be able to build WebCore/platform/sql/SQLiteStatement.cpp.

According to the SQLite headers

** The SQLITE_VERSION_NUMBER is an integer with the value 
** (X*1000000 + Y*1000 + Z). For example, for version "3.1.1beta", 
** SQLITE_VERSION_NUMBER is set to 3001001. To detect if they are using 
** version 3.1.1 or greater at compile time, programs may use the test 
** (SQLITE_VERSION_NUMBER>=3001001).

Patch coming up.
Comment 1 doug turner 2007-11-19 09:17:33 PST
Created attachment 17399 [details]
Patch 1.
Comment 2 Alp Toker 2007-11-19 10:02:44 PST
Landed in r27910.