Bug 160486 - run-javascriptcore-tests should accept multiple --extra-tests
Summary: run-javascriptcore-tests should accept multiple --extra-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-02 18:41 PDT by Filip Pizlo
Modified: 2016-08-02 19:39 PDT (History)
2 users (show)

See Also:

Attachments
the patch (2.13 KB, patch)
2016-08-02 18:42 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-08-02 18:41:06 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-08-02 18:42:29 PDT 
Created attachment 285182 [details]
the patch
Comment 2 Filip Pizlo 2016-08-02 18:59:31 PDT 
Landed in https://trac.webkit.org/changeset/204060
Comment 3 Saam Barati 2016-08-02 19:38:48 PDT 
I forgot to ask but does this work with the extra tests environment variable?
Comment 4 Filip Pizlo 2016-08-02 19:39:35 PDT 
(In reply to comment #3)
> I forgot to ask but does this work with the extra tests environment variable?

Yes.  It's now additive.  Previously it was destructive: --extra-tests would override the environment variable.  Now you get the sum of the two.