Bug 160484 – iOS doesn't support indeterminate checkboxes

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Chris Rebert]

Specification:
https://html.spec.whatwg.org/#dom-input-indeterminate

Does this work in other (mobile) browsers?:
Yes; see http://caniuse.com/#feat=indeterminate-checkbox

Steps to reproduce:
1. Open http://output.jsbin.com/hopasu/quiet in iOS Safari

Expected result:
The middle checkbox should be displayed as being indeterminate.
(For comparison, on macOS Safari, the indeterminate status is displayed by
having the checkbox contain a horizontal bar (instead of a check mark) on a blue background.)

Actual result:
The middle checkbox is displayed the same as the unchecked top checkbox.

+1

[Radar WebKit Bug Importer]

<rdar://problem/31143185>

+1 Still a bug. This should get fixed.

[Aditya Keerthi]

Created attachment 346567 [details]
Patch

[EWS Watchlist]

Comment on attachment 346567 [details]
Patch

Attachment 346567 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8757357

New failing tests:
fast/forms/indeterminate.html

[EWS Watchlist]

Created attachment 346577 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Aditya Keerthi]

Created attachment 346631 [details]
Patch

[Wenson Hsieh]

Comment on attachment 346631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346631&action=review

Looks good! Just a couple of minor comments...

> Source/WebCore/rendering/RenderThemeIOS.mm:374
> +static void drawJoinedLines(CGContextRef context, Vector<CGPoint> points, CGLineCap lineCap, float lineWidth, Color strokeColor)

This should probably be a const Vector<CGPoint>& (or Vector<CGPoint>&& combined with WTFMove at the call site).

> LayoutTests/fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html:8
> +function runTest()

Nit - it would be simpler to just have `document.querySelector("input").indeterminate = true;` in the script tag without wrapping it in runTest() and waiting until the load event, but this is okay too.

[Aditya Keerthi]

Created attachment 346633 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 346633 [details]
Patch

Clearing flags on attachment: 346633

Committed r234609: <https://trac.webkit.org/changeset/234609>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[HM100]

I don’t see any changes to the indeterminate checkboxes even in iOS 12. Tested it now

[HM100]

(In reply to HM100 from comment #12)
> I don’t see any changes to the indeterminate checkboxes even in iOS 12.
> Tested it now

Has that change rollbacked moments before the iOS12?

[Tim Horton]

(In reply to HM100 from comment #13)
> (In reply to HM100 from comment #12)
> > I don’t see any changes to the indeterminate checkboxes even in iOS 12.
> > Tested it now
> 
> Has that change rollbacked moments before the iOS12?

Trunk WebKit doesn't track a particular iOS release. The bug is fixed in trunk WebKit, but Apple doesn't comment on if/when that will make it into a release.

[Wenson Hsieh]

(In reply to Tim Horton from comment #14)
> (In reply to HM100 from comment #13)
> > (In reply to HM100 from comment #12)
> > > I don’t see any changes to the indeterminate checkboxes even in iOS 12.
> > > Tested it now
> > 
> > Has that change rollbacked moments before the iOS12?
> 
> Trunk WebKit doesn't track a particular iOS release. The bug is fixed in
> trunk WebKit, but Apple doesn't comment on if/when that will make it into a
> release.

Indeed!

We can let you know once this has been released in a public beta; before then, another option is to build trunk WebKit for iOS Simulator (against iOS 12) by following the instructions here: <https://webkit.org/building-webkit>, and try out indeterminate checkboxes on iOS.