160482 – Freeze the last of the Objective-C bindings

RESOLVED FIXED 160482

Freeze the last of the Objective-C bindings

https://bugs.webkit.org/show_bug.cgi?id=160482

Summary Freeze the last of the Objective-C bindings

Anders Carlsson

Reported 2016-08-02 18:02:10 PDT

Freeze the last of the Objective-C bindings

Attachments
Patch (224.24 KB, patch) 2016-08-02 18:07 PDT, Anders Carlsson	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2016-08-02 18:07:01 PDT

Created attachment 285173 [details] Patch

WebKit Commit Bot

Comment 2 2016-08-02 18:09:40 PDT

Attachment 285173 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/objc/DOMElement.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMElement.mm:38: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMElement.h:35: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMTextEvent.mm:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMText.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMText.mm:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:26: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:46: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:47: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:48: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:49: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:51: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:52: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:53: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/objc/DOMNamedNodeMap.mm:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMNamedNodeMap.mm:33: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMCharacterData.mm:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMAttr.mm:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMEntity.mm:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMProcessingInstruction.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMProcessingInstruction.mm:33: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMNode.mm:43: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMCDATASection.mm:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMDOMImplementation.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMDOMImplementation.mm:34: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMDocumentFragment.mm:33: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMEntityReference.mm:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/bindings/objc/DOMNodeInternal.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/objc/DOMDocument.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMDocument.mm:64: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMNodeList.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMNodeList.mm:33: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMDocumentType.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/bindings/objc/DOMComment.mm:29: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 47 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2016-08-03 09:54:37 PDT

Committed r204083: <http://trac.webkit.org/changeset/204083>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Anders Carlsson

Reported

2016-08-02 18:02 PDT

Modified

2016-08-03 09:54 PDT History

CC List

2 users Show

URL

Keywords

Depends on

Blocks