Bug 160479 - REGRESSION(r203368): broke some test262 tests
Summary: REGRESSION(r203368): broke some test262 tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 143247
Blocks:
  Show dependency tree / graph
 
Reported: 2016-08-02 17:01 PDT by Filip Pizlo
Modified: 2016-08-03 11:52 PDT (History)
10 users (show)

See Also:

Attachments
the patch (4.86 KB, patch)
2016-08-03 11:27 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-08-02 17:01:14 PDT 
Specifically:

JSTests/test262/test/built-ins/Object/freeze/15.2.3.9-2-c-2.js
JSTests/test262/test/built-ins/Object/freeze/15.2.3.9-2-c-3.js
JSTests/test262/test/built-ins/Object/freeze/15.2.3.9-2-c-4.js

Which can be run with:

jsc JSTests/test262/harness/assert.js JSTests/test262/harness/sta.js JSTests/test262/harness/propertyHelper.js <testFile>
Comment 1 Filip Pizlo 2016-08-03 11:15:10 PDT 
Wow, that's a silly goof.  The optimization ended up setting ReadOnly on Access properties, which would prevent setters from being invoked.  That's easy to fix.
Comment 2 Filip Pizlo 2016-08-03 11:27:00 PDT 
Created attachment 285253 [details]
the patch
Comment 3 Mark Lam 2016-08-03 11:33:00 PDT 
Comment on attachment 285253 [details]
the patch

r=me
Comment 4 Filip Pizlo 2016-08-03 11:52:37 PDT 
Landed in https://trac.webkit.org/changeset/204093