RESOLVED FIXED 160477
Drop custom bindings code for HTMLSelectElement.remove() 
https://bugs.webkit.org/show_bug.cgi?id=160477
Summary Drop custom bindings code for HTMLSelectElement.remove()
Chris Dumez
Reported 2016-08-02 16:30:16 PDT
Drop custom bindings code for HTMLSelectElement.remove() and use overloading instead.
Attachments
Patch (3.20 KB, patch)
2016-08-02 16:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.09 KB, patch)
2016-08-02 16:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-02 16:45:00 PDT
Bindings look like: EncodedJSValue JSC_HOST_CALL jsHTMLSelectElementPrototypeFunctionRemove(ExecState* state) { size_t argsCount = std::min<size_t>(1, state->argumentCount()); if (argsCount == 0) { return jsHTMLSelectElementPrototypeFunctionRemove1(state); } if (argsCount == 1) { JSValue distinguishingArg = state->uncheckedArgument(0); if (distinguishingArg.isObject() && asObject(distinguishingArg)->inherits(JSHTMLOptionElement::info())) return jsHTMLSelectElementPrototypeFunctionRemove3(state); if (distinguishingArg.isNumber()) return jsHTMLSelectElementPrototypeFunctionRemove2(state); return jsHTMLSelectElementPrototypeFunctionRemove2(state); } return throwVMTypeError(state); }
Chris Dumez
Comment 2 2016-08-02 16:51:21 PDT
Created attachment 285162 [details] Patch
Chris Dumez
Comment 3 2016-08-02 16:57:53 PDT
Created attachment 285164 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-02 19:57:41 PDT
Comment on attachment 285164 [details] Patch Clearing flags on attachment: 285164 Committed r204064: <http://trac.webkit.org/changeset/204064>
WebKit Commit Bot
Comment 5 2016-08-02 19:57:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.