Bug 160472 - Temporary redirected m3u8 streaming stopped working.
Summary: Temporary redirected m3u8 streaming stopped working.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on: 160607
Blocks:
  Show dependency treegraph
 
Reported: 2016-08-02 15:40 PDT by Jeremy Jones
Modified: 2016-08-05 14:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.75 KB, patch)
2016-08-03 15:10 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2016-08-02 15:40:22 PDT
Temporary redirected m3u8 streaming stopped working.
Comment 1 Jeremy Jones 2016-08-02 15:41:24 PDT
rdar://problem/27592694
Comment 2 Jeremy Jones 2016-08-03 15:10:38 PDT
Created attachment 285282 [details]
Patch
Comment 3 Alex Christensen 2016-08-03 17:03:46 PDT
Comment on attachment 285282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285282&action=review

This whole thing is unfortunate.  r=me.  This covers up bugs even more!

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:590
> +

This space should probably be removed so we can see that the above comment applies to the below code.

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:594
> +        if (mimeType.isEmpty() || mimeType == "application/octet-stream" || mimeType == "text/plain") {

could you add a test with a text/plain mime type?

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:673
> +

ditto.
Comment 4 WebKit Commit Bot 2016-08-04 11:49:38 PDT
Comment on attachment 285282 [details]
Patch

Clearing flags on attachment: 285282

Committed r204128: <http://trac.webkit.org/changeset/204128>
Comment 5 WebKit Commit Bot 2016-08-04 11:49:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2016-08-05 13:56:12 PDT
Re-opened since this is blocked by bug 160607
Comment 7 Jon Lee 2016-08-05 14:21:46 PDT
We're going to solve this problem in a different way.