Bug 160469 - [Mac] media/pip-video-going-into-fullscreen.html is a flaky failure
Summary: [Mac] media/pip-video-going-into-fullscreen.html is a flaky failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-02 15:04 PDT by Ada Chan
Modified: 2016-08-03 11:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.36 KB, patch)
2016-08-02 16:25 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Patch (13.20 KB, patch)
2016-08-02 16:50 PDT, Ada Chan 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-08-02 15:04:57 PDT 
media/pip-video-going-into-fullscreen.html is flaky.

@@ -3,7 +3,6 @@
 Going into Picture-in-Picture
 EXPECTED (video.webkitPresentationMode == 'picture-in-picture') OK
 Going into Full Screen from Picture-in-Picture
-EXPECTED (document.webkitCurrentFullScreenElement == '[object HTMLVideoElement]') OK
-EXPECTED (video.webkitPresentationMode == 'fullscreen') OK
+Presentation mode changes more than once going into fullscreen from picture-in-picture. FAIL
 END OF TEST

It looks like when we go from Picture-in-Picture to Fullscreen on Mac, the presentation mode changes from "picture-in-picture" to "fullscreen", and then from "fullscreen" to "inline".
Comment 1 Ada Chan 2016-08-02 15:05:22 PDT 
<rdar://problem/26901714>
Comment 2 Ada Chan 2016-08-02 16:25:17 PDT 
Created attachment 285157 [details]
Patch
Comment 3 Ada Chan 2016-08-02 16:50:51 PDT 
Created attachment 285161 [details]
Patch
Comment 4 Ada Chan 2016-08-02 16:51:56 PDT 
Updated patch to stop marking media/pip-video-going-into-fullscreen.html as flaky.
Comment 5 Eric Carlson 2016-08-03 10:38:06 PDT 
Comment on attachment 285161 [details]
Patch

Thanks Ada!
Comment 6 Ada Chan 2016-08-03 11:14:19 PDT 
Thanks Eric!

Committed:
https://trac.webkit.org/changeset/204088