Bug 160468 - Remove unused functions in URL
Summary: Remove unused functions in URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-02 15:02 PDT by Alex Christensen
Modified: 2016-08-02 15:32 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2016-08-02 15:03 PDT, Alex Christensen
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-08-02 15:02:52 PDT
Remove unused functions in URL
Comment 1 Alex Christensen 2016-08-02 15:03:23 PDT
Created attachment 285144 [details]
Patch
Comment 2 Geoffrey Garen 2016-08-02 15:04:54 PDT
Comment on attachment 285144 [details]
Patch

r=me

Do we have TestWebKitAPI tests for URL?
Comment 3 WebKit Commit Bot 2016-08-02 15:04:58 PDT
Attachment 285144 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2016-08-02 15:05:33 PDT
(In reply to comment #2)
> Do we have TestWebKitAPI tests for URL?
We have a few such tests.
Comment 5 Darin Adler 2016-08-02 15:09:42 PDT
Comment on attachment 285144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285144&action=review

> Source/WebCore/platform/URL.h:-198
> -    void print() const;

This function is intended to be used in the debugger. How did you determine it was unused?
Comment 6 Alex Christensen 2016-08-02 15:12:25 PDT
(In reply to comment #5)
> Comment on attachment 285144 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285144&action=review
> 
> > Source/WebCore/platform/URL.h:-198
> > -    void print() const;
> 
> This function is intended to be used in the debugger. How did you determine
> it was unused?
I searched for print() and found no call sites.  I could leave it if you think it's useful
Comment 7 Alex Christensen 2016-08-02 15:32:10 PDT
https://trac.webkit.org/changeset/204046
I left the print function in.  Not everybody debugs exactly like I do :)