WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160466
Drop custom bindings for FormData.append()
https://bugs.webkit.org/show_bug.cgi?id=160466
Summary
Drop custom bindings for FormData.append()
Chris Dumez
Reported
2016-08-02 14:56:11 PDT
Drop custom bindings for FormData.append(). We no longer need them now that we have proper support for overloads.
Attachments
Patch
(12.95 KB, patch)
2016-08-02 15:22 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-08-02 15:03:36 PDT
Generated code looks like so: EncodedJSValue JSC_HOST_CALL jsDOMFormDataPrototypeFunctionAppend(ExecState* state) { size_t argsCount = std::min<size_t>(3, state->argumentCount()); if (argsCount == 2) { JSValue distinguishingArg = state->uncheckedArgument(1); if (distinguishingArg.isObject() && asObject(distinguishingArg)->inherits(JSBlob::info())) return jsDOMFormDataPrototypeFunctionAppend2(state); return jsDOMFormDataPrototypeFunctionAppend1(state); } if (argsCount == 3) { return jsDOMFormDataPrototypeFunctionAppend2(state); } return argsCount < 2 ? throwVMError(state, createNotEnoughArgumentsError(state)) : throwVMTypeError(state); }
Chris Dumez
Comment 2
2016-08-02 15:22:15 PDT
Created
attachment 285147
[details]
Patch
WebKit Commit Bot
Comment 3
2016-08-02 15:56:59 PDT
Comment on
attachment 285147
[details]
Patch Clearing flags on attachment: 285147 Committed
r204048
: <
http://trac.webkit.org/changeset/204048
>
WebKit Commit Bot
Comment 4
2016-08-02 15:57:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug