Bug 160466 - Drop custom bindings for FormData.append()
Summary: Drop custom bindings for FormData.append()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://xhr.spec.whatwg.org/#interfac...
Keywords:
Depends on: 160394
Blocks:
  Show dependency treegraph
 
Reported: 2016-08-02 14:56 PDT by Chris Dumez
Modified: 2016-08-02 15:57 PDT (History)
7 users (show)

See Also:


Attachments
Patch (12.95 KB, patch)
2016-08-02 15:22 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-02 14:56:11 PDT
Drop custom bindings for FormData.append(). We no longer need them now that we have proper support for overloads.
Comment 1 Chris Dumez 2016-08-02 15:03:36 PDT
Generated code looks like so:
EncodedJSValue JSC_HOST_CALL jsDOMFormDataPrototypeFunctionAppend(ExecState* state)
{
    size_t argsCount = std::min<size_t>(3, state->argumentCount());
    if (argsCount == 2) {
        JSValue distinguishingArg = state->uncheckedArgument(1);
        if (distinguishingArg.isObject() && asObject(distinguishingArg)->inherits(JSBlob::info()))
            return jsDOMFormDataPrototypeFunctionAppend2(state);
        return jsDOMFormDataPrototypeFunctionAppend1(state);
    }
    if (argsCount == 3) {
        return jsDOMFormDataPrototypeFunctionAppend2(state);
    }
    return argsCount < 2 ? throwVMError(state, createNotEnoughArgumentsError(state)) : throwVMTypeError(state);
}
Comment 2 Chris Dumez 2016-08-02 15:22:15 PDT
Created attachment 285147 [details]
Patch
Comment 3 WebKit Commit Bot 2016-08-02 15:56:59 PDT
Comment on attachment 285147 [details]
Patch

Clearing flags on attachment: 285147

Committed r204048: <http://trac.webkit.org/changeset/204048>
Comment 4 WebKit Commit Bot 2016-08-02 15:57:04 PDT
All reviewed patches have been landed.  Closing bug.