Bug 160424 - Freeze all the DOMHTML* Objective-C bindings
Summary: Freeze all the DOMHTML* Objective-C bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-01 13:55 PDT by Anders Carlsson
Modified: 2016-08-02 12:25 PDT (History)
1 user (show)

See Also:


Attachments
Patch (743.93 KB, patch)
2016-08-01 14:08 PDT, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-01 13:55:02 PDT
Freeze all the DOMHTML* Objective-C bindings
Comment 1 Anders Carlsson 2016-08-01 14:08:39 PDT
Created attachment 285040 [details]
Patch
Comment 2 Tim Horton 2016-08-01 14:09:56 PDT
Comment on attachment 285040 [details]
Patch

rs=me
Comment 3 Anders Carlsson 2016-08-01 14:18:00 PDT
Committed r203988: <http://trac.webkit.org/changeset/203988>
Comment 4 Darin Adler 2016-08-02 09:55:11 PDT
I just noticed that we are generating a lot of Objective-C bindings that then are not migrated by MigrateHeaders. I wonder if we can get away with just not generating any of those?
Comment 5 Anders Carlsson 2016-08-02 12:01:25 PDT
(In reply to comment #4)
> I just noticed that we are generating a lot of Objective-C bindings that
> then are not migrated by MigrateHeaders. I wonder if we can get away with
> just not generating any of those?

Yeah, I've noticed that too. There are a couple of DOMEvent headers that aren't being installed, but they're used in 

Class kitClass(WebCore::Event* impl)

I think we can simply fall back to DOMEvent for them.
Comment 6 Anders Carlsson 2016-08-02 12:02:58 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > I just noticed that we are generating a lot of Objective-C bindings that
> > then are not migrated by MigrateHeaders. I wonder if we can get away with
> > just not generating any of those?
> 
> Yeah, I've noticed that too. There are a couple of DOMEvent headers that
> aren't being installed, but they're used in 
> 
> Class kitClass(WebCore::Event* impl)
> 
> I think we can simply fall back to DOMEvent for them.

There are also CSS related classes that aren't installed but used in

Class kitClass(WebCore::CSSRule* impl)

and

Class kitClass(WebCore::CSSValue* impl)

We can probably get away with returning [DOMCSSRule class] and [DOMCSSValue class] respectively.
Comment 7 Darin Adler 2016-08-02 12:15:43 PDT
There are also lots of others, like the Apple Pay ones.
Comment 8 Anders Carlsson 2016-08-02 12:25:01 PDT
(In reply to comment #7)
> There are also lots of others, like the Apple Pay ones.

Yes, those aren't even built!