Bug 160407 - [Fetch API] Pass directly FetchRequest fetch options to ThreadableLoader
Summary: [Fetch API] Pass directly FetchRequest fetch options to ThreadableLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 151937
  Show dependency tree / graph
 
Reported: 2016-08-01 09:45 PDT by youenn fablet
Modified: 2016-08-01 23:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (58.86 KB, patch)
2016-08-01 09:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (59.51 KB, patch)
2016-08-01 23:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-08-01 09:45:36 PDT 
We should pass directly FetchRequest fetch options to ThreadableLoader
Comment 1 youenn fablet 2016-08-01 09:51:47 PDT 
Created attachment 285016 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-01 09:53:11 PDT 
Attachment 285016 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ResourceLoaderOptions.h:86:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 youenn fablet 2016-08-01 23:18:09 PDT 
Created attachment 285077 [details]
Patch for landing
Comment 4 youenn fablet 2016-08-01 23:20:23 PDT 
(In reply to comment #3)
> Created attachment 285077 [details]
> Patch for landing

Updating patch for win build
Comment 5 WebKit Commit Bot 2016-08-01 23:21:05 PDT 
Attachment 285077 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ResourceLoaderOptions.h:86:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2016-08-01 23:48:16 PDT 
Comment on attachment 285077 [details]
Patch for landing

Clearing flags on attachment: 285077

Committed r204014: <http://trac.webkit.org/changeset/204014>
Comment 7 WebKit Commit Bot 2016-08-01 23:48:20 PDT 
All reviewed patches have been landed.  Closing bug.