Adopt MediaRemote "seek to playback position"
<rdar://problem/27547583>
Created attachment 285019 [details] Proposed patch.
Attachment 285019 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm:115: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/audio/PlatformMediaSession.h:134: The parameter name "argument" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 285019 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=285019&action=review > Source/WebCore/platform/mac/RemoteCommandListenerMac.mm:129 > + CFNumberRef positionRef = static_cast<CFNumberRef>(CFDictionaryGetValue(options, kMRMediaRemoteOptionPlaybackPosition)); > + if (positionRef) > + CFNumberGetValue(positionRef, kCFNumberDoubleType, &argument.asDouble); > + platformCommand = PlatformMediaSession::SeekToPlaybackPositionCommand; Does this mean that if you can't get the playback position, you'll seek to the start?
Comment on attachment 285019 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=285019&action=review >> Source/WebCore/platform/mac/RemoteCommandListenerMac.mm:129 >> + platformCommand = PlatformMediaSession::SeekToPlaybackPositionCommand; > > Does this mean that if you can't get the playback position, you'll seek to the start? Good point, I will fix that.
Created attachment 285024 [details] Updated patch for the bots.
Attachment 285024 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm:118: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/audio/PlatformMediaSession.h:134: The parameter name "argument" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r203982: http://trac.webkit.org/changeset/203982
Plus r204082 to fix a problem on iOS.
And r204375 to update MediaRemoteSPI.h