Bug 160399 – DocumentThreadableLoader should pass the fetch mode to underlying loader code

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Currently, it sets the fetch mode to NoCors and does the fetch mode additional checks (CORS typically) on its own.

[youenn fablet]

Created attachment 284997 [details]
Patch

[youenn fablet]

Created attachment 285001 [details]
Rebasing

[Alex Christensen]

Comment on attachment 285001 [details]
Rebasing

View in context: https://bugs.webkit.org/attachment.cgi?id=285001&action=review

> LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:18
> +FAIL: PASS: Cross-domain access allowed.

Is this a correct expectation?

[youenn fablet]

Comment on attachment 285001 [details]
Rebasing

View in context: https://bugs.webkit.org/attachment.cgi?id=285001&action=review

>> LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:18
>> +FAIL: PASS: Cross-domain access allowed.
> 
> Is this a correct expectation?

The URL contains credentials so loading should stop as per the spec. But the underlying loading code is removing the credentials so loading continues but without any credential.

> LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html:57
> +// Underlying HTTP stack currently removes credentials from redirection URL, hence loading is successful.

Here is the comment related to the odd expectation

[Darin Adler]

We should change the test to expect correct behavior.

[youenn fablet]

Created attachment 285239 [details]
Adding more tests

[Alex Christensen]

Comment on attachment 285239 [details]
Adding more tests

View in context: https://bugs.webkit.org/attachment.cgi?id=285239&action=review

> Source/WebCore/loader/DocumentThreadableLoader.cpp:233
> +        request = ResourceRequest();

{ }

> LayoutTests/imported/w3c/ChangeLog:31
> [phone]  Youenn Fablet  <[e-mail]>

two changelog entries :(

[Build Bot]

Comment on attachment 285239 [details]
Adding more tests

Attachment 285239 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1805299

New failing tests:
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker.html

[Build Bot]

Created attachment 285242 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 285239 [details]
Adding more tests

Attachment 285239 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1805304

New failing tests:
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker.html

[Build Bot]

Created attachment 285244 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 285239 [details]
Adding more tests

Attachment 285239 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1805305

New failing tests:
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker.html

[Build Bot]

Created attachment 285245 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[youenn fablet]

(In reply to comment #12)
> Comment on attachment 285239 [details]
> Adding more tests
> 
> Attachment 285239 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/1805305
> 
> New failing tests:
> imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-worker.
> html
> imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials-
> worker.html

These tests need to be rebased with the changes to the redirect.py script that is now correctly generating redirection URLs.

[youenn fablet]

Created attachment 285306 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 285306 [details]
Patch for landing

Clearing flags on attachment: 285306

Committed r204117: <http://trac.webkit.org/changeset/204117>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.