Bug 160397 - MediaResourceLoader::requestResource should take a ResourceRequest&& as input
Summary: MediaResourceLoader::requestResource should take a ResourceRequest&& as input
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-01 01:05 PDT by youenn fablet
Modified: 2016-10-11 23:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.84 KB, patch)
2016-08-01 01:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.37 KB, patch)
2016-08-01 03:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2016-10-11 10:12 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-08-01 01:05:05 PDT 
This would allow potentially removing a ResourceRequest copy.
Comment 1 youenn fablet 2016-08-01 01:06:45 PDT 
Created attachment 284989 [details]
Patch
Comment 2 youenn fablet 2016-08-01 03:19:09 PDT 
Created attachment 285000 [details]
Patch
Comment 3 WebKit Commit Bot 2016-08-01 03:20:54 PDT 
Attachment 285000 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 youenn fablet 2016-10-11 10:12:00 PDT 
Created attachment 291273 [details]
Patch
Comment 5 Alex Christensen 2016-10-11 12:23:12 PDT 
Comment on attachment 291273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291273&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:583
> +        // FIXME: request should be moved for efficiency

I see no reason not to do that right now.
Comment 6 youenn fablet 2016-10-11 23:05:48 PDT 
Comment on attachment 291273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291273&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:583
>> +        // FIXME: request should be moved for efficiency
> 
> I see no reason not to do that right now.

request cannot be moved currently as it is a const.
This is a result of priv->notifier.notify taking a std::function.
Comment 7 WebKit Commit Bot 2016-10-11 23:29:11 PDT 
Comment on attachment 291273 [details]
Patch

Clearing flags on attachment: 291273

Committed r207190: <http://trac.webkit.org/changeset/207190>
Comment 8 WebKit Commit Bot 2016-10-11 23:29:15 PDT 
All reviewed patches have been landed.  Closing bug.