Bug 160395 – AX: Simulated touch events are not working on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

The dispatchTouchEvent() in AccessibilityObject::press() is not working.

[Radar WebKit Bug Importer]

<rdar://problem/27633599>

[Simon Fraser (smfr)]

rdar://problem/27633597

[Nan Wang]

Created attachment 285125 [details]
Initial patch

[chris fleizach]

Comment on attachment 285125 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285125&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:926
> +#if PLATFORM(IOS)

Should this be guarded instead by ENABLE_TOUCH_EVENTS

[Nan Wang]

Comment on attachment 285125 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285125&action=review

>> Source/WebCore/accessibility/AccessibilityObject.cpp:926
>> +#if PLATFORM(IOS)
> 
> Should this be guarded instead by ENABLE_TOUCH_EVENTS

Because hasTouchEventListener() is only in iOS. And the function body of dispatchedTouchEvent() is guarded by IOS_TOUCH_EVENTS. Do you think I should change it to IOS_TOUCH_EVENTS?

[Simon Fraser (smfr)]

Comment on attachment 285125 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285125&action=review

> Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:275
> +        m_isPotentialTap = true;

Is this changing the behavior of both createPlatformTouchEvent and createPlatformSimulatedTouchEvent? Is that desired?

[Nan Wang]

Comment on attachment 285125 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285125&action=review

>> Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:275
>> +        m_isPotentialTap = true;
> 
> Is this changing the behavior of both createPlatformTouchEvent and createPlatformSimulatedTouchEvent? Is that desired?

This only affects createPlatformSimulatedTouchEvent.

[Build Bot]

Comment on attachment 285125 [details]
Initial patch

Attachment 285125 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1800128

New failing tests:
platform/ios-simulator/ios/accessibility/press-fires-touch-events.html

[Build Bot]

Created attachment 285131 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Nan Wang]

Working on the test failure now.

[Nan Wang]

Created attachment 285145 [details]
Patch

Fixed test.

[Nan Wang]

Created attachment 285153 [details]
Patch

Test seemed to be timing out. I think we don't need to do the async test.

[Build Bot]

Comment on attachment 285153 [details]
Patch

Attachment 285153 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1800937

New failing tests:
platform/ios-simulator/ios/accessibility/press-fires-touch-events.html

[Build Bot]

Created attachment 285160 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Simon Fraser (smfr)]

Don't forget that touch event code in OpenSource is different (and mostly disabled).

[chris fleizach]

(In reply to comment #15)
> Don't forget that touch event code in OpenSource is different (and mostly
> disabled).

Is there a way to test code that's guarded by IOS_TOUCH_EVENTS with a layout test?

[Nan Wang]

Created attachment 285166 [details]
Patch

Skipping the touch event test on wk2

[WebKit Commit Bot]

Comment on attachment 285166 [details]
Patch

Clearing flags on attachment: 285166

Committed r204062: <http://trac.webkit.org/changeset/204062>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.