Bug 160388 - AX: Add a check for touch event listener on iOS accessibility object
Summary: AX: Add a check for touch event listener on iOS accessibility object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-31 02:28 PDT by Nan Wang
Modified: 2016-07-31 13:04 PDT (History)
11 users (show)

See Also:


Attachments
patch (9.41 KB, patch)
2016-07-31 02:47 PDT, Nan Wang
no flags Details | Formatted Diff | Diff
patch (9.39 KB, patch)
2016-07-31 11:33 PDT, Nan Wang
no flags Details | Formatted Diff | Diff
patch (9.34 KB, patch)
2016-07-31 11:40 PDT, Nan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2016-07-31 02:28:34 PDT
Expose the check on the wrapper object so that we can handle simulating the touch on iOS.
Comment 1 Radar WebKit Bug Importer 2016-07-31 02:28:45 PDT
<rdar://problem/27629346>
Comment 2 Nan Wang 2016-07-31 02:47:33 PDT
Created attachment 284963 [details]
patch
Comment 3 chris fleizach 2016-07-31 11:01:05 PDT
Comment on attachment 284963 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284963&action=review

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:89
> +        return false;

Will this also take care of the case where the listener is on a parent node?
Comment 4 Nan Wang 2016-07-31 11:33:25 PDT
Created attachment 284966 [details]
patch

update from review
Comment 5 Nan Wang 2016-07-31 11:40:37 PDT
Created attachment 284967 [details]
patch

better styling
Comment 6 chris fleizach 2016-07-31 12:01:06 PDT
Comment on attachment 284967 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284967&action=review

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:88
> +        if (node->hasEventListeners(eventNames().touchstartEvent) || node->hasEventListeners(eventNames().touchendEvent))

We may have code for this already. Can you do a search for ontouchstart and see if there's something in ax alread
Comment 7 Nan Wang 2016-07-31 12:29:07 PDT
Comment on attachment 284967 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284967&action=review

>> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:88
>> +        if (node->hasEventListeners(eventNames().touchstartEvent) || node->hasEventListeners(eventNames().touchendEvent))
> 
> We may have code for this already. Can you do a search for ontouchstart and see if there's something in ax alread

I searched ontouchstart, ontouchend, touchstart and touchend. And there's no related accessibility code.
Comment 8 WebKit Commit Bot 2016-07-31 13:04:12 PDT
Comment on attachment 284967 [details]
patch

Clearing flags on attachment: 284967

Committed r203955: <http://trac.webkit.org/changeset/203955>
Comment 9 WebKit Commit Bot 2016-07-31 13:04:16 PDT
All reviewed patches have been landed.  Closing bug.