Bug 160388 – AX: Add a check for touch event listener on iOS accessibility object

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

Expose the check on the wrapper object so that we can handle simulating the touch on iOS.

[Radar WebKit Bug Importer]

<rdar://problem/27629346>

[Nan Wang]

Created attachment 284963 [details]
patch

[chris fleizach]

Comment on attachment 284963 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284963&action=review

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:89
> +        return false;

Will this also take care of the case where the listener is on a parent node?

[Nan Wang]

Created attachment 284966 [details]
patch

update from review

[Nan Wang]

Created attachment 284967 [details]
patch

better styling

[chris fleizach]

Comment on attachment 284967 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284967&action=review

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:88
> +        if (node->hasEventListeners(eventNames().touchstartEvent) || node->hasEventListeners(eventNames().touchendEvent))

We may have code for this already. Can you do a search for ontouchstart and see if there's something in ax alread

[Nan Wang]

Comment on attachment 284967 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284967&action=review

>> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:88
>> +        if (node->hasEventListeners(eventNames().touchstartEvent) || node->hasEventListeners(eventNames().touchendEvent))
> 
> We may have code for this already. Can you do a search for ontouchstart and see if there's something in ax alread

I searched ontouchstart, ontouchend, touchstart and touchend. And there's no related accessibility code.

[WebKit Commit Bot]

Comment on attachment 284967 [details]
patch

Clearing flags on attachment: 284967

Committed r203955: <http://trac.webkit.org/changeset/203955>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.