Bug 160381 - Assertion failure while setting the length of an ArrayClass array.
Summary: Assertion failure while setting the length of an ArrayClass array.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-30 09:19 PDT by Mark Lam
Modified: 2016-07-30 18:09 PDT (History)
10 users (show)

See Also:

Attachments
proposed patch. (5.72 KB, patch)
2016-07-30 09:31 PDT, Mark Lam 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (809.06 KB, application/zip)
2016-07-30 10:18 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.44 MB, application/zip)
2016-07-30 10:28 PDT, Build Bot 		no flags Details
proposed patch: with rebased test result. (6.71 KB, patch)
2016-07-30 14:12 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-07-30 09:19:11 PDT 
When setting large length values, we're currently treating ArrayClass as a ContiguousIndexingType array.  This results in an assertion failure.
Comment 1 Mark Lam 2016-07-30 09:20:34 PDT 
<rdar://problem/27328703>
Comment 2 Mark Lam 2016-07-30 09:31:11 PDT 
Created attachment 284943 [details]
proposed patch.
Comment 3 Build Bot 2016-07-30 10:18:36 PDT 
Comment on attachment 284943 [details]
proposed patch.

Attachment 284943 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1780339

New failing tests:
platform/mac/fast/dom/wrapper-classes-objc.html
Comment 4 Build Bot 2016-07-30 10:18:39 PDT 
Created attachment 284945 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-07-30 10:28:11 PDT 
Comment on attachment 284943 [details]
proposed patch.

Attachment 284943 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1780350

New failing tests:
platform/mac/fast/dom/wrapper-classes-objc.html
Comment 6 Build Bot 2016-07-30 10:28:14 PDT 
Created attachment 284946 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Mark Lam 2016-07-30 14:12:19 PDT 
Created attachment 284954 [details]
proposed patch: with rebased test result.
Comment 8 WebKit Commit Bot 2016-07-30 18:09:53 PDT 
Comment on attachment 284954 [details]
proposed patch: with rebased test result.

Clearing flags on attachment: 284954

Committed r203952: <http://trac.webkit.org/changeset/203952>
Comment 9 WebKit Commit Bot 2016-07-30 18:09:58 PDT 
All reviewed patches have been landed.  Closing bug.