WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160372
We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
https://bugs.webkit.org/show_bug.cgi?id=160372
Summary
We should not keep the JavaScript tests inside the Source/JavaScriptCore/ dir...
Keith Miller
Reported
2016-07-29 19:25:20 PDT
Buckle your seatbelts, this is going to be a big patch.
Attachments
Add attachment
proposed patch, testcase, etc.
Keith Miller
Comment 1
2016-08-01 00:28:38 PDT
It's happening! I hope this doesn't break everything... I hope no one commits anything in JavaScriptCore or Tools for the next ~2 hours.
Keith Miller
Comment 2
2016-08-01 00:31:48 PDT
Oh, well that was faster than I thought. I assumed that svn didn't do smart things with moving directories. That's a pleasant surprise.
mitz
Comment 3
2016-08-01 00:32:15 PDT
Is this a duplicate of
bug 160180
?
Keith Miller
Comment 4
2016-08-01 00:33:57 PDT
(In reply to
comment #3
)
> Is this a duplicate of
bug 160180
?
Looks like it. I'll mark the other one as a dup though.
Keith Miller
Comment 5
2016-08-01 00:34:22 PDT
Landed in
https://trac.webkit.org/r203972
.
Keith Miller
Comment 6
2016-08-01 00:38:15 PDT
***
Bug 160180
has been marked as a duplicate of this bug. ***
Michael Catanzaro
Comment 7
2016-08-11 13:09:27 PDT
Just noticed this. It might make sense to move TestWebKitAPI up to the toplevel as well? It doesn't make much sense to me to have LayoutTests and JSTests and ManualTests and PerformanceTests at the toplevel, but bury API tests under Tools. Thoughts?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug