Bug 160357 – Refactor DFG::Node::hasLocal() to accessesStack()

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

The Node class currently has two accessors, hasVariableAccessData() and hasLocal() that provide the same answer.  As part of the work for <https://bugs.webkit.org/show_bug.cgi?id=160355> - "JSVALUE64: Pass arguments in platform argument registers when making JavaScript calls", there is need for distinct accessors.  One of those accessors is needed to answer the question: "Does this node have a reference to a VariableAccessData object?".  A second accessor is needed to answer the question: "Does this node read/write the stack?".  That second question implies the need for such a node to have a reference to the appropriate VariableAccessData object, but within the DFG and FTL tier asserts a much stronger fact about the node.

This patch is for the work to refactor hasLocal() to accessesStack().

[Michael Saboff]

Created attachment 284903 [details]
Patch

[Filip Pizlo]

Comment on attachment 284903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284903&action=review

> Source/JavaScriptCore/ChangeLog:14
> +        The hasVariableAccessData() check now iplies no more than the node has a

*implies

[Michael Saboff]

Committed r203923: <http://trac.webkit.org/changeset/203923>