Bug 160353 – [iOS] HTMLMediaElement::updateVolume() calls MediaPlayer::volume() on null media player

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Daniel Bates]

The test media/video-muted-after-setting-page-muted-state.html crashes when run in WebKitTestRunner.

[Daniel Bates]

Created attachment 284890 [details]
Stack trace

From <https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Debug%20WK2%20(Tests)/r203907%20(3836)/media/video-muted-after-setting-page-muted-state-crash-log.txt>.

[Daniel Bates]

m_player can be nullptr at <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.cpp?rev=203917#L4821>.

[Daniel Bates]

(In reply to comment #2)
> m_player can be nullptr at
> <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.
> cpp?rev=203917#L4821>.

Notice that below this iOS-specific code we bail out early if m_player is nullptr, <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.cpp?rev=203917#L4827>.

[Daniel Bates]

(In reply to comment #3)
> (In reply to comment #2)
> > m_player can be nullptr at
> > <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.
> > cpp?rev=203917#L4821>.
> 
> Notice that below this iOS-specific code we bail out early if m_player is
> nullptr,
> <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.
> cpp?rev=203917#L4827>.

err, this code is in a #else-clause

For some reason we seem to expect that m_player is non-null for iOS.

[Daniel Bates]

Created attachment 284896 [details]
Patch

[Eric Carlson]

Comment on attachment 284896 [details]
Patch

Thanks Dan!

[Build Bot]

Comment on attachment 284896 [details]
Patch

Attachment 284896 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1775781

New failing tests:
media/track/track-remove-quickly.html

[Build Bot]

Created attachment 284909 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Daniel Bates]

(In reply to comment #7)
> Comment on attachment 284896 [details]
> Patch
> 
> Attachment 284896 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/1775781
> 
> New failing tests:
> media/track/track-remove-quickly.html

This test failure is not related to this change and is covered by bug #160367.

[Daniel Bates]

Committed r203930: <http://trac.webkit.org/changeset/203930>