Bug 160352 – Refactor data passed along for a "GetRecord" request

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Refactor data passed along for a "GetRecord" request

This is laying the groundwork for some of the additional APIs that have been added in V2 of the spec.

[Brady Eidson]

Created attachment 284888 [details]
Patch

[Brady Eidson]

I don't know why the linux's aren't picking up the new header in WK2 - That directory *is* included in the WebCore includes directory list, and I can't currently recall a different step necessary to get a header to copy over.

Any Linux folks know what's up?

Or Alex?

[Michael Catanzaro]

I don't know what's wrong, CCing more Linux folks.

We don't want to block your work, so if we don't figure it out soon, go ahead and commit and we'll fix it up when we get a chance. Thanks as always for asking first.

[Brady Eidson]

Lots of other Monday-morning work in my queue right now.

I'll hold off on landing until much later today.

[WebKit Commit Bot]

Comment on attachment 284888 [details]
Patch

Rejecting attachment 284888 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 284888, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
hing file Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h
patching file Source/WebKit2/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in
patching file Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp
patching file Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1794883

[Brady Eidson]

Created attachment 285074 [details]
Patch for landing

[Carlos Garcia Campos]

That's a known issue, it has nothing to do with linux, but with cmake based ports I would say and the way we generate the forwarding headers. The thing is that if  generated code, like message receivers, uses a WebCore include, we don't generate the forwarding header for that one. The trick is adding that include in the non-generated code where that is needed.

[Carlos Garcia Campos]

Created attachment 285076 [details]
Patch for landing

[Carlos Garcia Campos]

Comment on attachment 285076 [details]
Patch for landing

All green now :-)

[Alex Christensen]

Hooray!  Carlos to the rescue!  Thanks!
*obligatory grumbling about differences in build systems*

[WebKit Commit Bot]

Comment on attachment 285076 [details]
Patch for landing

Clearing flags on attachment: 285076

Committed r204018: <http://trac.webkit.org/changeset/204018>

[Brady Eidson]

(In reply to comment #10)
> Hooray!  Carlos to the rescue!  Thanks!
> *obligatory grumbling about differences in build systems*

👍😞