Add support for Element.getAttributeNames()

[Chris Dumez]

Add support for Element.getAttributeNames():
- https://dom.spec.whatwg.org/#dom-element-getattributenames

Firefox already supports this, Chrome does not yet.

[Chris Dumez]

Created attachment 284836 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 284836 [details]
Patch

Clearing flags on attachment: 284836

Committed r203852: <http://trac.webkit.org/changeset/203852>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 284836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284836&action=review

> Source/WebCore/dom/Element.cpp:505
> +    if (!hasAttributes())
> +        return attributesVector;

Is this an important optimization?

[Chris Dumez]

Comment on attachment 284836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284836&action=review

>> Source/WebCore/dom/Element.cpp:505
>> +        return attributesVector;
> 
> Is this an important optimization?

It has the benefit of checking that elementData is not null or the call to attributesIterator() below would crash.