Bug 160326 - Do not set negative rate on AVSampleBufferRenderSynchronizer.
Summary: Do not set negative rate on AVSampleBufferRenderSynchronizer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-28 16:19 PDT by zalan
Modified: 2016-07-29 16:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.50 KB, patch)
2016-07-28 16:33 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2016-07-28 16:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.60 KB, patch)
2016-07-29 16:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-07-28 16:19:17 PDT 
rdar://problem/27355214
Comment 1 zalan 2016-07-28 16:33:23 PDT 
Created attachment 284833 [details]
Patch
Comment 2 zalan 2016-07-28 16:34:28 PDT 
Created attachment 284834 [details]
Patch
Comment 3 Eric Carlson 2016-07-29 09:38:32 PDT 
Comment on attachment 284834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284834&action=review

Thank you Zalan!

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:476
> +    m_rate = std::max<double>(rate, 0);

Nit: I think a comment about why this is necessary would be helpful because we should support negative rates.
Comment 4 zalan 2016-07-29 16:13:20 PDT 
Created attachment 284912 [details]
Patch
Comment 5 WebKit Commit Bot 2016-07-29 16:43:09 PDT 
Comment on attachment 284912 [details]
Patch

Clearing flags on attachment: 284912

Committed r203924: <http://trac.webkit.org/changeset/203924>
Comment 6 WebKit Commit Bot 2016-07-29 16:43:13 PDT 
All reviewed patches have been landed.  Closing bug.