Bug 160324 - ASSERTION FAILED in errorProtoFuncToString() when Error name is a single char string.
Summary: ASSERTION FAILED in errorProtoFuncToString() when Error name is a single char...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
: 149253 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-07-28 15:57 PDT by Mark Lam
Modified: 2016-08-04 17:22 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (2.43 KB, patch)
2016-07-28 16:03 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-07-28 15:57:45 PDT 
The issue is that errorProtoFuncToString() is using jsNontrivialString() to generate the error string even when the name string can be a single character string.  This is incorrect.  We should be using jsString() instead.
Comment 1 Mark Lam 2016-07-28 15:58:58 PDT 
<rdar://problem/27389572>
Comment 2 Mark Lam 2016-07-28 16:03:03 PDT 
Created attachment 284827 [details]
proposed patch.
Comment 3 Keith Miller 2016-07-28 16:06:37 PDT 
Comment on attachment 284827 [details]
proposed patch.

r=me.
Comment 4 Mark Lam 2016-07-28 18:25:08 PDT 
Thanks for the review.  Landed in r203853: <http://trac.webkit.org/r203853>.
Comment 5 Mark Lam 2016-08-04 17:22:14 PDT 
*** Bug 149253 has been marked as a duplicate of this bug. ***