Bug 160307 - Parameter to table.deleteRow() / body.deleteRow() should be mandatory
Summary: Parameter to table.deleteRow() / body.deleteRow() should be mandatory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-28 12:08 PDT by Chris Dumez
Modified: 2016-07-28 14:08 PDT (History)
9 users (show)

See Also:

Attachments
Patch (16.08 KB, patch)
2016-07-28 13:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (16.12 KB, patch)
2016-07-28 13:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-28 12:08:18 PDT 
Parameter to HTMLTableElement.deleteRow() should be mandatory:
- https://html.spec.whatwg.org/multipage/tables.html#the-table-element

Firefox and Chrome agree with the specification.
Comment 2 Chris Dumez 2016-07-28 13:15:11 PDT 
Created attachment 284808 [details]
Patch
Comment 3 WebKit Commit Bot 2016-07-28 13:35:11 PDT 
Comment on attachment 284808 [details]
Patch

Rejecting attachment 284808 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 284808, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 203831 = a89df4adb9c2be0d220746eed2eff456e122ea25
r203832 = b76b93d011d411fd7f44a36a77e1f61802f00078
r203833 = d81978c3d6b3bb76bf06f2e4df46bd670ab5025d
r203834 = be4e87b8c19f642324685165da818ea4b2d7ac09
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/1769260
Comment 4 Chris Dumez 2016-07-28 13:39:16 PDT 
Created attachment 284811 [details]
Patch
Comment 5 WebKit Commit Bot 2016-07-28 14:08:38 PDT 
Comment on attachment 284811 [details]
Patch

Clearing flags on attachment: 284811

Committed r203840: <http://trac.webkit.org/changeset/203840>
Comment 6 WebKit Commit Bot 2016-07-28 14:08:43 PDT 
All reviewed patches have been landed.  Closing bug.