Bug 160296 – First parameter to SVGDocument.createEvent() should be mandatory

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Chris Dumez]

First parameter to SVGDocument.createEvent() should be mandatory:
- https://www.w3.org/TR/SVG2/struct.html#InterfaceDocumentExtensions
- https://dom.spec.whatwg.org/#document

Firefox and Chrome agree with the specification.

[Chris Dumez]

Created attachment 284784 [details]
Patch

[Alex Christensen]

Comment on attachment 284784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284784&action=review

> LayoutTests/svg/dom/SVGDocument-createEvent-expected.txt:6
> +PASS svgDocument.createEvent() threw exception TypeError: Not enough arguments.

Chrome canary and firefox fail this test :(

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 284784 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284784&action=review
> 
> > LayoutTests/svg/dom/SVGDocument-createEvent-expected.txt:6
> > +PASS svgDocument.createEvent() threw exception TypeError: Not enough arguments.
> 
> Chrome canary and firefox fail this test :(

Only because my test checks for a specific exception message and their exception message is different?

[Alex Christensen]

Comment on attachment 284784 [details]
Patch

Yep, I just saw the red FAIL.  They indeed just have a different message.  No problem

[WebKit Commit Bot]

Comment on attachment 284784 [details]
Patch

Clearing flags on attachment: 284784

Committed r203821: <http://trac.webkit.org/changeset/203821>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.