Bug 160290 – Fetch Response built-ins should use @makeThisTypeError

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Fetch Response built-ins should use @makeThisTypeError

[youenn fablet]

Created attachment 284769 [details]
Patch

[Build Bot]

Comment on attachment 284769 [details]
Patch

Attachment 284769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1766963

New failing tests:
fetch/fetch-error-messages.html

[Build Bot]

Created attachment 284772 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 284769 [details]
Patch

Attachment 284769 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1766964

New failing tests:
fetch/fetch-error-messages.html

[Build Bot]

Created attachment 284773 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 284769 [details]
Patch

Attachment 284769 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1766965

New failing tests:
fetch/fetch-error-messages.html

[Build Bot]

Created attachment 284774 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Build Bot]

Comment on attachment 284769 [details]
Patch

Attachment 284769 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1766970

New failing tests:
fetch/fetch-error-messages.html

[Build Bot]

Created attachment 284775 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[youenn fablet]

Created attachment 284776 [details]
Fixing test expectation

[Alex Christensen]

Comment on attachment 284776 [details]
Fixing test expectation

View in context: https://bugs.webkit.org/attachment.cgi?id=284776&action=review

> Source/WebCore/Modules/fetch/FetchResponse.js:102
> -    if (!this instanceof @Response)
> -        throw new @TypeError("Function should be called on a Response");
> +    if (!(this instanceof @Response))
> +        return @Promise.@reject(@makeThisTypeError("Response", "arrayBuffer"));

This seems like a significant change in behavior from throwing to rejecting.  Worth noting in ChangeLog.  Is it correct?  Why didn't you make the same change with clone?

[youenn fablet]

(In reply to comment #11)
> Comment on attachment 284776 [details]
> Fixing test expectation
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284776&action=review
> 
> > Source/WebCore/Modules/fetch/FetchResponse.js:102
> > -    if (!this instanceof @Response)
> > -        throw new @TypeError("Function should be called on a Response");
> > +    if (!(this instanceof @Response))
> > +        return @Promise.@reject(@makeThisTypeError("Response", "arrayBuffer"));
> 
> This seems like a significant change in behavior from throwing to rejecting.
> Worth noting in ChangeLog.  Is it correct?  Why didn't you make the same
> change with clone?

Promise returning functions should reject promises, hence why updating these functions except for clone.
I'll rebase the patch and update the change log

[youenn fablet]

Created attachment 284861 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 284861 [details]
Patch

Clearing flags on attachment: 284861

Committed r203961: <http://trac.webkit.org/changeset/203961>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.